forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: Use workspacePath from instance if available in CodeIndexManager and QdrantVectorStore #6901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NaccOll
wants to merge
2
commits into
RooCodeInc:main
from
NaccOll:hotfix-multiple-fold-workspace-qdrant
Closed
fix: Use workspacePath from instance if available in CodeIndexManager and QdrantVectorStore #6901
NaccOll
wants to merge
2
commits into
RooCodeInc:main
from
NaccOll:hotfix-multiple-fold-workspace-qdrant
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and QdrantVectorStore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes to improve multi-folder workspace support. While the approach of using instance-specific workspace paths is good, I found some critical issues that need attention before merging.
|
merge into #6904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
PR - Changes Requested
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6897
In multi-folder workspaces, mimic the history and index status, binding the dialog to the CWD when creating a new ChatView. This will prevent CWD switching during a conversation and further confusion.
Important
Use instance-specific
workspacePathinCodeIndexManagerandQdrantVectorStoreto ensure consistent workspace handling.CodeIndexManager, usethis.workspacePathif available instead ofgetWorkspacePath()ininitialize()and_recreateServices().QdrantVectorStore, usethis.workspaceRootif available instead ofgetWorkspacePath()indeletePointsByMultipleFilePaths().workspaceRootproperty toQdrantVectorStoreto store the workspace path.This description was created by
for 58b0b64. You can customize this summary. It will automatically update as commits are pushed.